Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing sharedassets0.assets file in language patch does not terminate install #193

Open
drojf opened this issue Dec 28, 2022 · 0 comments

Comments

@drojf
Copy link
Collaborator

drojf commented Dec 28, 2022

Currently, if a matching sharedassets0.assets file is not found in the language patch, the installer will just hope for the best and use the default one.

It may be a better idea to stop the install with an error if this happens.

I think the way it works currently is that we extract the whole language patch archive directly, which automatically overwrites the sharedassets0.assets. But it may be better to leave the install as-is, without the language patch installed, if we know for sure it won't work.


Also see #192 if this is still to be treated as a warning, not an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant