Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer does not report out-of-disk-space error if disk space runs out #159

Open
drojf opened this issue Jul 16, 2021 · 0 comments
Open

Comments

@drojf
Copy link
Collaborator

drojf commented Jul 16, 2021

If disk space runs out during the download phase, the installer will report a generic error about the download stage failing, rather than explicitly telling you that disk space ran out (this might also happen during extraction with 7zip). This is mainly because we don't properly parse the output of aria2c to determine the error (even just copying the first line of the error message from aria2c may be better).

The installer should parse the aria2c output to see if disk space ran out, then immediately exit and report out-of-disk space.

TODO:

  1. Report less generic error if disk space runs out
  2. Stop download/extract immediately if disk space runs out (currently will retry 3 times!)
  3. Log disk space on both drives (the target drive and the 'current' drive used for temp files) to installer log (currently neither is logged!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant