Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioned options #141

Open
drojf opened this issue Feb 5, 2021 · 2 comments
Open

Add versioned options #141

drojf opened this issue Feb 5, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@drojf
Copy link
Collaborator

drojf commented Feb 5, 2021

Versioned options would let us do stuff like have the Umineko PS3 sprites as an option which is installed by default, so people can revert to PS3 sprites without re-installing the whole mod.

The reason we can't do this currently is that mod options are always installed if selected - so the Umineko PS3 sprites would be installed on every update (which is a huge file).

The main issue is dealing with:

  • If you change your selection for an option, the option should always be installed/there needs to be a version for each possible selection
  • if install order of options is important, any options which are installed before this option should also be installed (not sure if our games require this to be true though)
  • should allow non-versioned options which are always installed (if they are small and have no dependencies), but havent thought about this much (not sure about this one)
  • on update, reading the currently selected option, and restoring that into the installer page, so you don't need to re-select all the options every time you update (this might be difficult)
@drojf drojf added the enhancement New feature or request label Feb 5, 2021
@andOlga
Copy link
Member

andOlga commented Feb 5, 2021

If I recall correctly, the same package that includes PS3 sprites also includes a whole bunch of other stuff, so not installing it is simply not an option (and I'm kinda afraid of separating it into a sprite-only pack in case the other sprite packs are missing stuff).
Therefore, this could be solved simply by adding the PS3 pack as a mod option (e.g. "Revert to PS3 sprites") while also keeping it as part of the base install.

@drojf
Copy link
Collaborator Author

drojf commented Feb 5, 2021

that sounds good - I'll try that out for now (well...at some point), as it doesn't require any changes to the installer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants